apollographql / apollo-ios

📱  A strongly-typed, caching GraphQL client for iOS, written in Swift.
https://www.apollographql.com/docs/ios/
MIT License
3.89k stars 728 forks source link

feat: SECOPS-2525 - add semgrep job #3314

Closed svc-secops closed 10 months ago

svc-secops commented 10 months ago

Motivation / Implements

This PR adds or updates the necessary configuration to enable Semgrep to run on PRs on this repo. The Apollo Security team uses Semgrep to test our source for potential security vulnerabilities.

Once this is accepted and merged, the Security team plans to make a passing Semgrep check a requirement for PRs to merge into this repo. This will prevent net-new severe issues from being introduced. The job proposed by this PR runs in a diff-aware mode, so it will only run Semgrep on the files that have changed in a given PR.

In the event that a severe issue is detected on a PR, the CI job will add a comment to the PR associated with the detection to provide instructions on how to properly resolve the detection. The comment added to PRs will also include instructions on how to get further support if needed.

If maintainers reviewing this PR have questions, please reach out in the #security channel in Slack or contact Matt Peake directly at matt[.]peake@apollographql[.]com.

Existing Findings

Semgrep does not currently detect any severe issues in this repo.

Changed

netlify[bot] commented 10 months ago

Deploy Preview for apollo-ios-docs failed.

Name Link
Latest commit 0a8df64a08277ed68c9e1f571e503a3a2d156547
Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/659ea8d2fe19590008b4daa2
github-actions[bot] commented 10 months ago

We do not accept PRs directly to the 'apollo-ios' repo. All development is done through the 'apollo-ios-dev' repo, please see the CONTRIBUTING guide for more information.