search

apollographql / apollo-ios

📱  A strongly-typed, caching GraphQL client for iOS, written in Swift.
https://www.apollographql.com/docs/ios/
MIT License
3.87k stars 717 forks source link

apollo-ios-codegen 1.8.0 CustomScalar is 'should not be edited.' #3323

Closed matsudamper closed 8 months ago

matsudamper commented 8 months ago

Summary

Schema/CustomScalars/*.swift header output has been changed.

1.8.0

// @generated
// This file was automatically generated and should not be edited.

1.7.1

// @generated
// This file was automatically generated and can be edited to
// implement advanced custom scalar functionality.
//
// Any changes to this file will not be overwritten by future
// code generation execution.

Version

1.8.0

Steps to reproduce the behavior

do code gen. I use ApolloCodegenLib with swift.

Logs

No response

Anything else?

No response

matsudamper commented 8 months ago

define https://github.com/apollographql/apollo-ios-codegen/blob/0b53900755ffbf5d9ad84f123d54a51cf4fd3615/Sources/ApolloCodegenLib/Templates/TemplateRenderer.swift#L56

no problem SchemaConfigurationTemplate https://github.com/apollographql/apollo-ios-codegen/blob/0b53900755ffbf5d9ad84f123d54a51cf4fd3615/Sources/ApolloCodegenLib/Templates/SchemaConfigurationTemplate.swift#L13

problem CustomScalarTemplate https://github.com/apollographql/apollo-ios-codegen/blob/0b53900755ffbf5d9ad84f123d54a51cf4fd3615/Sources/ApolloCodegenLib/Templates/CustomScalarTemplate.swift#L17

github-actions[bot] commented 8 months ago

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.