apollographql / apollo-ios

📱  A strongly-typed, caching GraphQL client for iOS, written in Swift.
https://www.apollographql.com/docs/ios/
MIT License
3.89k stars 728 forks source link

Investigation: Allow codegen projects to modify generated filenames #3361

Closed calvincestari closed 6 months ago

calvincestari commented 7 months ago

Related to https://github.com/apollographql/apollo-ios/issues/3357.

This issue exists mostly to resolve the Xcode quirk of not being able to handle multiple files with the same name even though they are in different paths. Additionally it can help alleviate the existing problem of input type filenames clashing with other object type filenames.

We've been resistant to this type of feature in the past but the difference with this design is that Apollo iOS is not the one to be making the change based on an individual rule, such as prefixing the schema name to filenames, etc. Rather it is the client project that is being given the ability to modify the name.

AnthonyMDev commented 6 months ago

The team has discussed this issue and we don't believe it's an appropriate fix for #3557. This would add a lot of complexity to the code generation engine and open up a lot of edge cases for us to deal with going forward.

The correct way to deal with this situation is to put each of your different schema's generated files into seperate targets that are linked against by your application targets.

github-actions[bot] commented 6 months ago

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.