search

apollographql / apollo-ios

📱  A strongly-typed, caching GraphQL client for iOS, written in Swift.
https://www.apollographql.com/docs/ios/
MIT License
3.89k stars 728 forks source link

Fix building ApolloSQLite with Xcode 16 #3391

Closed rastersize closed 5 months ago

rastersize commented 5 months ago

In Xcode 16, or rather Foundation in the iOS 18/etc. SDKs, there’s a new Expression type. The SQLite library also expose this type. This caused an issue compiling the SQLiteDotSwiftDatabase.swift file, as it imports both libraries. This PR disambiguates it for the compiler.

With this change the project once again builds with Xcode 16.

Screenshot 2024-06-10 at 3 59 48 PM

apollo-cla commented 5 months ago

@rastersize: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

netlify[bot] commented 5 months ago

Deploy request for apollo-ios-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit b4f804f734941487dd6572ed2955a26589795a3b
github-actions[bot] commented 5 months ago

We do not accept PRs directly to the 'apollo-ios' repo. All development is done through the 'apollo-ios-dev' repo, please see the CONTRIBUTING guide for more information.

BrentMifsud commented 5 months ago

any word on when this is going out in a release?

BobaFetters commented 5 months ago

@BrentMifsud This will go out in a release this week

BobaFetters commented 4 months ago

Quick update on this, we will be doing a release containing this on Monday.