search

apollographql / apollo-ios

📱  A strongly-typed, caching GraphQL client for iOS, written in Swift.
https://www.apollographql.com/docs/ios/
MIT License
3.89k stars 728 forks source link

apollo-ios-xcframework doesn't add bundle identifier to the Info.plist for the created xcframework #3425

Closed Karram-Ayman closed 3 months ago

Karram-Ayman commented 3 months ago

Summary

The apollo-ios-xcframework does not automatically add a CFBundleIdentifier to the Info.plist files of the created XCFrameworks when using the provided Makefile script. As a result, when you try to link Apollo.xcframework and ApolloAPI.xcframework in an Xcode project using the "Embed and Sign" option, the build may succeed, but a runtime error will occur. This error indicates that ApolloAPI.framework (or Apollo.framework) is missing a CFBundleIdentifier in its Info.plist, which is required for proper framework embedding.

Screenshot 2024-08-14 at 1 16 05 PM

Version

1.14.1

Steps to reproduce the behavior

  1. Following the make script to create xcframework in https://github.com/apollographql/apollo-ios-xcframework
  2. Add created xcframework to Xcode project link frameworks target with embed & Sign
  3. Run the project

Logs

Payload/MyProject.app/Frameworks/ApolloAPI.framework did not have a CFBundleIdentifier in its Info.plist

Anything else?

No response

BobaFetters commented 3 months ago

Thanks for the report @Karram-Ayman have a PR up that should resolve this https://github.com/apollographql/apollo-ios-xcframework/pull/18

github-actions[bot] commented 3 months ago

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.