apollographql / apollo-ios

📱  A strongly-typed, caching GraphQL client for iOS, written in Swift.
https://www.apollographql.com/docs/ios/
MIT License
3.87k stars 714 forks source link

can we get @inlinable on properties when generating code into SPM package? #3431

Open ZeeWanderer opened 2 weeks ago

ZeeWanderer commented 2 weeks ago

Question

Is there an option to add inlining to spm package?

When generating files into an SPM package its a separate compile module so unless properties/functions are marked with @inlinable to my understanding no inlining will occur. In particular wrapper properties like

public var results: [Result] { __data["results"] }

Will benefit from it.

calvincestari commented 2 weeks ago

Hi @ZeeWanderer 👋🏻 - no, there is not any configuration option at the moment to generate @inlinable property accessors.

I'll take this feature request to our next team planning meeting and gather opinion from the rest of the team; could be a week or so before I get back to you though.