search

apollographql / apollo-kotlin

:rocket:  A strongly-typed, caching GraphQL client for the JVM, Android, and Kotlin multiplatform.
https://www.apollographql.com/docs/kotlin
MIT License
3.74k stars 653 forks source link

Add bump kotlin shadow job #5999

Closed BoD closed 3 months ago

netlify[bot] commented 3 months ago

Deploy request for apollo-android-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit 86583a30bee0d97810e7bf0b8abee253a05cc705
martinbonnin commented 3 months ago

Looks like this duplicates a lot of the "pr" workflow? Could you instead have a branch with the latest Kotlin version that gets recreated every night and triggers the "pr" workflow manually using a workflow_dispatch event?

A question is whether we want the shadow branch to have a PR always open. Pro: makes us see when it fails. Con: creates noise in the PR list.

Also, what about fetching the latest Kotlin version automatically? Possibly even using nightlies?

BoD commented 3 months ago

Looks like this duplicates a lot of the "pr" workflow? Could you instead have a branch with the latest Kotlin version that gets recreated every night and triggers the "pr" workflow manually using a workflow_dispatch event?

Good point! I like the idea of having a (draft) PR open so we can see if it's "red" :) But I agree it's a bit of noise too. I'll try that route, and if we're tired of seeing it, we can reevaluate this.

what about fetching the latest Kotlin version automatically? Possibly even using nightlies?

👀 interesting idea, let me see...

martinbonnin commented 3 months ago

I'll try that route, and if we're tired of seeing it, we can reevaluate this.

Sounds good 👍 .

what about fetching the latest Kotlin version automatically? Possibly even using nightlies?

Thinking more about this, I think nightlies make more sense if we want to send timely feedback. We could have 2 PRs but for the sake of simplicity, I think I'd prefer just one.