False positive in field merging validation

apollographql / apollo-rs

Spec compliant GraphQL Tools in Rust.

Apache License 2.0

576 stars 45 forks source link

False positive in field merging validation #755

Closed goto-bus-stop closed 11 months ago

goto-bus-stop commented 11 months ago

Spotted while running comparative testing with graphql-js validation in the Apollo Router. apollo-rs produces a validation error claiming two different types are selected to the same field name, but graphql-js does not.

I think this may be a regression in the validation port to 1.0 as we started getting rare false positives since then.

Minimal repro TBD

goto-bus-stop commented 11 months ago

I guess PR titles don't close issues 🤪