Open joergbaier opened 1 month ago
Typing updates for @types/express
& @types/express-serve-static-core
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70563
Breaking changes are listed in the migration guide, which is not yet up to date. Besides the listed changes there is also Node.js min supported version: 18. The primary feature is proper handling of asynchronous handlers.
I think it would be a good start if community members wanted to publish Express 5 integrations separately (perhaps under the @as-integrations
npm org / apollo-server-integrations
GitHub org)! While we could add a @apollo/server/express5
directory directly to Apollo Server, it might be challenging to do so in a way that uses different dependencies for two different parts of the same npm module, so getting this in core might be more likely a thing for the next major version of AS, which is not currently scheduled.
I made types. Enjoy :)
I am using express5 beta with apollo server 4 for the past year without any problems.
After upgrading @types/express
and @types/express-serve-static-core
to v5, I needed to override the version in apollo server to avoid type mismatches. e.g. for pnpm:
{
"pnpm": {
"overrides": {
"@types/express": "5.0.0",
"@types/express-serve-static-core": "5.0.0"
}
}
}
@apollo/server
has express v4 as a dependency. After several years, express is moving forward with releasing v5 (currently published asnext
tag). Having support for v5 here would unblock and encourage people to upgrade.https://www.npmjs.com/package/express?activeTab=versions https://github.com/expressjs/express/releases/tag/v5.0.0
At this time, I have not checked for breaking changes in this repo, but wanted to open this issue to get things rolling. Any changes could be published under the
next
tag as well.