apollographql / apollo-tooling

✏️ Apollo CLI for client tooling (Mostly replaced by Rover)
https://apollographql.com
MIT License
3.04k stars 467 forks source link

Sort types when generating #2576

Closed gravyboat closed 1 year ago

gravyboat commented 2 years ago

I don't know if this will be merged or considered since it seems like the repo is no longer maintained but I'd love to get this in and addressed as it's quite annoying when doing type generation to constantly run in to this. I'd prefer not to give my information to Apollo via the license agreement, so I'd be okay with this code being taken and merged by an actual contributor if that's possible. Let me know.

Types are not currently sorted when regenerating the graphql schema. This results in constantly changing types based on what was queried first leading to unnecessary merge conflicts as the type order changes. This addresses the issue by sorting the type array before it is returned.<!-- Thanks for filing a pull request on Apollo Tooling!

Please look at the following checklist to ensure that your PR can be accepted quickly: -->

TODO:

apollo-cla commented 2 years ago

@gravyboat: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

gravyboat commented 1 year ago

It's been a year with no updates from the maintainers, closing.