apollographql / apollo-tooling

✏️ Apollo CLI for client tooling (Mostly replaced by Rover)
https://apollographql.com
MIT License
3.04k stars 467 forks source link

chore(deps): update dependency moment to v2.29.2 [security] #2593

Closed renovate[bot] closed 2 years ago

renovate[bot] commented 2 years ago

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change Age Adoption Passing Confidence
moment 2.29.1 -> 2.29.2 age adoption passing confidence
moment (source) dependencies patch 2.29.1 -> 2.29.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2022-24785

Impact

This vulnerability impacts npm (server) users of moment.js, especially if user provided locale string, eg fr is directly used to switch moment locale.

Patches

This problem is patched in 2.29.2, and the patch can be applied to all affected versions (from 1.0.1 up until 2.29.1, inclusive).

Workarounds

Sanitize user-provided locale name before passing it to moment.js.

References

Are there any links users can visit to find out more?

For more information

If you have any questions or comments about this advisory:


Release Notes

moment/moment ### [`v2.29.2`](https://togithub.com/moment/moment/blob/HEAD/CHANGELOG.md#​2292-See-full-changelog-httpsgistgithubcomichernev1904b564f6679d9aac1ae08ce13bc45c) [Compare Source](https://togithub.com/moment/moment/compare/2.29.1...2.29.2) - Release Apr 3 2022 Address https://github.com/moment/moment/security/advisories/GHSA-8hfj-j24r-96c4

Configuration

📅 Schedule: "" in timezone America/Los_Angeles.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.



This PR has been generated by WhiteSource Renovate. View repository job log here.

dargmuesli commented 2 years ago

Ping @trevor-scheer Saw that you'd been active on dependency maintenance a few days ago, an update would be much appreciated! :raised_hands:

nickpith commented 2 years ago

Even better would be to just do https://github.com/apollographql/apollo-tooling/issues/2323 and replace the usages of moment that don't seem to be needed. I'm more than happy to contribute a change if that would help.

trevor-scheer commented 2 years ago

Thanks for the ping! @nickpith I'd love a PR for that if you've got the availability for it.

And yes - my hope is to find the time to get this repo healthy (graphql /node versions current at the least) and cut new major versions for these packages. We do intend to EOL the packages in this repo at some point but there's still no clarity around when that will be nor do we have viable alternatives for all of the functionality here - so in the meantime I hope to keep the lights on. My main focus is on AS 4 right now, but I hope to dedicate some actual focus time to this project soon enough.

dargmuesli commented 2 years ago

That's amazing to hear! Thank you very much Trevor :pray:

nickpith commented 2 years ago

Created https://github.com/apollographql/apollo-tooling/pull/2595 to remove moment as a dependency of apollo-language-server. There was broader usage in the CLI so I didn't worry about that one.