apollographql / apollo

:rocket: Open source tools for GraphQL. Central repo for discussion.
https://www.apollographql.com
MIT License
2.61k stars 426 forks source link

Pink text in code tags is difficult to read #1133

Open jglovier opened 3 years ago

jglovier commented 3 years ago

The pink text in the code tags looks really fun and adds personality to the docs design, but it's difficult to read. Especially in articles like the Federation error codes doc where much of the page copy is in this format.

I'm also sad to report that it fails WCAG accessibility for color contrast pretty hard.

And finally, the fact that it is a bright color could easily confuse readers to wonder if it is in fact also a link. 😕

I know it's not as fun, but i'd suggest we move to simply black (or Apollo SpaceKit's black-base value of #191C23).

We could use something a little bit more fun and still has better contrast (like indigo-dark, #3F20BA), but my concern here still is that using any color is going to signal that it's a link, which in fact it is not.

Any objections to a PR that would update the code snippets to black-base?

(Note: to clarify, I'm only suggesting updating the styling for inline code ticks at this point; I consider syntax highlighting in the code blocks a much different matter because they're not read like prose, and generally I think the pink is much more appropriate there)

jglovier commented 3 years ago

For comparison, here's pink vs black vs indigo:

pink-base black-base indigo-dark
image image image
kuzmaMinin commented 3 years ago

тесто

kuzmaMinin commented 3 years ago

ну вы блин даете

kuzmaMinin commented 3 years ago

это все надо удалять