fix: [GH-267] Fix CacheOptions Related Types

apollographql / datasource-rest

A caching data source for REST APIs

MIT License

39 stars 20 forks source link

fix: [GH-267] Fix CacheOptions Related Types #268

Closed HishamAli81 closed 1 year ago

HishamAli81 commented 1 year ago

Fix RequestOptions.cacheOptions function return type to also return a non-promise value.
Fix propagation of the cache options generic type RequestOptions and AugmentedRequest.

Fixes #267

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

trevor-scheer commented 1 year ago

Hi @HishamAli81, this looks good to me. I added one more commit, would you take a look and let me know if you agree with the change? I think it makes sense to update the type of the fetch argument requestOpts as well. This allows us to clean up some spots where TS couldn't infer the type argument automatically.

HishamAli81 commented 1 year ago

Hi @HishamAli81, this looks good to me. I added one more commit, would you take a look and let me know if you agree with the change? I think it makes sense to update the type of the fetch argument requestOpts as well. This allows us to clean up some spots where TS couldn't infer the type argument automatically.

Looks good to me. Thanks!