apollographql / embeddable-explorer

MIT License
35 stars 12 forks source link

Still seeing stripe requests, sentry logs with `runTelemetry: false` #266

Closed trevor-scheer closed 1 year ago

trevor-scheer commented 1 year ago

I can make an actual repo if the zip file doesn't work. CodeSandbox isn't a good repro for this because of all the extra noise in the network tab.

npm i && npm start

Open network tab, observe request to stripe

image

server-typescript-1689955125468.zip

Reported here: https://github.com/apollographql/apollo-server/issues/7623

aclarknexient commented 1 year ago

I'm very glad that this will be worked on. Our corporate cybersecurity department has banned development tools that make unwanted external network requests!

mayakoneval commented 1 year ago

Hi thanks for the report! We have a fix in progress for this. I will update asap.

mayakoneval commented 1 year ago

Hi! I forgot to update on this, but we should have fixed this on Aug 8. Closing

aclarknexient commented 1 year ago

@mayakoneval unfortunately we are still seeing the calls to stripe and others. This was in a clean install with apolloserver 4.9.4.

The code used was:

import { ApolloServerPluginDrainHttpServer } from '@apollo/server/plugin/drainHttpServer';
import { ApolloServerPluginLandingPageLocalDefault, ApolloServerPluginLandingPageProductionDefault } from '@apollo/server/plugin/landingPage/default';

const server = new ApolloServer({
  schema,
  introspection: true,
  allowBatchedHttpRequests: true,
  plugins: [
    ApolloServerPluginDrainHttpServer({ httpServer }),
    process.env.NODE_ENV === 'production'
      ? ApolloServerPluginLandingPageProductionDefault({
        embed: {
          runTelemetry: false
        }
      })
      : ApolloServerPluginLandingPageLocalDefault({
        embed: {
          runTelemetry: false
        }
      }),
  ]
});
mayakoneval commented 1 year ago

replied over here ! https://github.com/apollographql/embeddable-explorer/issues/285

Thanks as always!