apollographql / embeddable-explorer

MIT License
35 stars 12 forks source link

Add wrapping error and move stacktrace to extensions #272

Open smyrick opened 1 year ago

smyrick commented 1 year ago

To provide at least a little more info, wrap the fetch function with a message to indicate that we had an issue calling the url, rather than is ambiguous TypeError that we get today

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c23444e2af6b7fe314d80f991da8ec8f71fbe2e8:

Sandbox Source
maya-test-embed-next Configuration
maya-test-embed-next Configuration
changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: c23444e2af6b7fe314d80f991da8ec8f71fbe2e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ---------------- | ----- | | @apollo/explorer | Patch | | @apollo/sandbox | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

smyrick commented 1 year ago

I have remove the options from the log for now

mayakoneval commented 1 year ago

going to test manually before merge and then I will merge myself

smyrick commented 7 months ago

@mayakoneval Is this something we can still merge?