Closed peakematt closed 1 year ago
Latest commit: 5e5ab8ff5587873df600a094e068b06bc1b54675
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 5e5ab8ff5587873df600a094e068b06bc1b54675:
Sandbox | Source |
---|---|
npm-embeddable-explorer (forked) | Configuration |
npm-embeddable-sandbox | Configuration |
maya-test-embed-next | Configuration |
maya-test-embed-next | Configuration |
🤔 I'm not quite sure why that one test failed? I don't think I changed anything that would impact it?
Motivation / Implements
This PR adds the necessary files to configure Gitleaks to run on PRs on this repo. The Apollo Security team uses Gitleaks to test our repositories for secrets.
Once this is accepted and merged, the Security team plans to make a passing Gitleaks check a requirement for PRs to merge into this repo. This will prevent secrets from being introduced to our repos.
In the event that a secret is detected on a repo, the CI job will add a comment to the PR associated with the detection to provide instructions on how to properly resolve the detection. Additionally, if a secret is detected, the Apollo Security team will be notified so that we can be available to assist in resolving the detection.
If maintainers reviewing this PR have questions, please see this Apollo-internal Slack link.
Changed
.circleci/config.yml
to this repo. This file contains appropriate configuration to enable Gitleaks as a CI check.