apollographql / federation-jvm

JVM support for Apollo Federation
https://www.apollographql.com/docs/federation/
MIT License
245 stars 65 forks source link

fix: default to not generate ftv1 traces #370

Closed dariuszkuc closed 7 months ago

dariuszkuc commented 7 months ago

Federation tracing should only be enabled if the Router/Gateway sends the proper ftv1 header and value. Currently trace data is generated even if the header is not specified which leads to unnecessary computations of data that will ultimately be discarded by the Router/Gateway.... If header is not specified, we should default to false to avoid those unnecessary computations.

See: https://www.apollographql.com/docs/federation/metrics/

Supersedes: https://github.com/apollographql/federation-jvm/pull/368

github-actions[bot] commented 7 months ago

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more: