search

apollographql / federation-jvm

JVM support for Apollo Federation
https://www.apollographql.com/docs/federation/
MIT License
245 stars 65 forks source link

feat: add flag to CacheControlInstrumentation to optionally allow max-age of zero #392

Closed trophied closed 3 months ago

trophied commented 3 months ago

This change adds an optional flag to CacheControlInstrumentation, allowZeroMaxAge, to allow consumers to configure the behavior such that resolved header can validly resolve a header value of max-age=0.

dariuszkuc commented 3 months ago

Linter failed -> can you run ./gradlew spotlessApply (this should apply auto format, there might be other linter issues that need manual fixing).

trophied commented 3 months ago

Linter failed -> can you run ./gradlew spotlessApply (this should apply auto format, there might be other linter issues that need manual fixing).

Sure thing, I must have missed re-running after changing some stuff out 👍