apollographql / federation-jvm

JVM support for Apollo Federation
https://www.apollographql.com/docs/federation/
MIT License
245 stars 65 forks source link

breaking: update to graphql-java 22 #395

Closed dariuszkuc closed 3 months ago

dariuszkuc commented 3 months ago

The only breaking change is to the caching instrumentation that relied on deprecated methods.

Disabling Spring subscription-callback lib until we get compatible Spring Boot release.

dariuszkuc commented 3 months ago

Failure is due to the change in graphql-java printer that no longer includes deprecation applications IF schema does not include built-in @deprecated directive definition.

github-actions[bot] commented 3 months ago

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

dariuszkuc commented 3 months ago

NOTE: large size of the PR is due to cleaning up how we store the test schemas. Actual breaking changes from graphql-java updates are localized to CacheControlInstrumentation (as it was using old deprecated instrumentation methods) and ServiceSDLPrinter (as there was a change in printing behavior of @deprecated directive as filtering built-in directives will now result in removal all deprecation notices).