search

apollographql / federation-next

Moved to the Router repository
https://github.com/apollographql/router/tree/dev/apollo-federation
Other
19 stars 1 forks source link

Ported maybe_dump_subgraph_schema from JS #248

Closed TylerBloom closed 5 months ago

TylerBloom commented 5 months ago

This PR addresses Jira ticket FED-53.

This method, ported from JS, appends additional information to error messages when attempting to extract subgraphs from a supergraph. Users can also set the environment variable APOLLO_FEDERATION_DEBUG_SUBGRAPHS to have the schema written to a file.

TylerBloom commented 5 months ago

After looking at the dependency differences, I decided to add chrono with all of the default features disabled except clock (to get the local time). This added 4 transitive dependencies, bringing the total number of deps from 71 to 76. Surprisingly, this is one fewer transitive deps than the minimum config for the time crate.

dariuszkuc commented 5 months ago

After looking at the dependency differences, I decided to add chrono with all of the default features disabled except clock (to get the local time). This added 4 transitive dependencies, bringing the total number of deps from 71 to 76. Surprisingly, this is one fewer transitive deps than the minimum config for the time crate.

@TylerBloom I believe the reason why time was mentioned is that this was already apollographql/router dependency so we wouldn't be adding any new dependencies (assuming we would keep those versions in sync).