Closed duckki closed 4 months ago
I split the extract_defer_from_operation
implementation into a separate branch. So, reviewing this PR is less painful.
I updated as Renée suggested and rebased.
By the way, if you push new commits without rebasing that makes it easier to see what changed since last review. We generally "merge with squash" to it all ends up as one commit in main
. If you want to preserve multiple commits without squashing, the final rebase can be done after the review is approved.
Thanks, @SimonSapin ! I pushed one last refactoring as suggested. Now, I'll go ahead and merge 😃
Implemented the following:
FetchInputs::add/add_all
methodswrap_input_selections
andcreate_fetch_initial_path
functionscompute_input_rewrites_on_key_fetch
functionhttps://apollographql.atlassian.net/browse/FED-37