FED-37: Port FetchInputs::add from GroupInputs.add

apollographql / federation-next

Moved to the Router repository

https://github.com/apollographql/router/tree/dev/apollo-federation

Other

19 stars 1 forks source link

FED-37: Port FetchInputs::add from GroupInputs.add #270

Closed duckki closed 4 months ago

duckki commented 4 months ago

Implemented the following:

FetchInputs::add/add_all methods
wrap_input_selections and create_fetch_initial_path functions
compute_input_rewrites_on_key_fetch function
And some various helper methods.

https://apollographql.atlassian.net/browse/FED-37

duckki commented 4 months ago

I split the extract_defer_from_operation implementation into a separate branch. So, reviewing this PR is less painful.

duckki commented 4 months ago

I updated as Renée suggested and rebased.

SimonSapin commented 4 months ago

By the way, if you push new commits without rebasing that makes it easier to see what changed since last review. We generally "merge with squash" to it all ends up as one commit in main. If you want to preserve multiple commits without squashing, the final rebase can be done after the review is approved.

duckki commented 4 months ago

Thanks, @SimonSapin ! I pushed one last refactoring as suggested. Now, I'll go ahead and merge 😃