search

apollographql / federation-rs

Contains source code for Apollo Federation's Rust<--> JavaScript interop
Other
35 stars 23 forks source link

Add EntityResolverArgumentMismatch error code #580

Closed pubmodmatt closed 1 month ago

pubmodmatt commented 1 month ago

Add the error type emitted by #apollographql/router/pull/5984. Cannot be merged (and build will fail) until that dependency PR is merged.

dylan-apollo commented 1 month ago

This is gonna be pretty common, where we accumulate new validation codes between releases. Should we keep a running next branch or something to keep these updated, and then merge that as part of the checklist you think?

dylan-apollo commented 1 month ago

(I just merged another change to apollo-federation's codes as well...)

pubmodmatt commented 1 month ago

This is gonna be pretty common, where we accumulate new validation codes between releases. Should we keep a running next branch or something to keep these updated, and then merge that as part of the checklist you think?

@dylan-apollo - That would make sense. We could also keep the builds working with something like:

[patch.crates-io]
apollo-federation = { git = 'https://github.com/apollographql/router.git', branch = 'next' }

Though removing that would be another checklist step.