search

apollographql / federation

🌐  Build and scale a single data graph across multiple services with Apollo's federation gateway.
https://apollographql.com/docs/federation/
Other
668 stars 254 forks source link

Don't ever add @shareable to subscription fields during schema upgrading #3094

Closed clenfest closed 4 months ago

clenfest commented 4 months ago

It could be valid to have two fields of the same that are not shareable if one of them is being overridden. Don't add @sharable to subscription fields and just let it be a composition error if neither are overrides. As @shareable is not allowed on a subscription field, they should never exist there in any case.

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 057f0a049b9b18af499e7e3eaf0c96b883fd358e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages | Name | Type | | --------------------------------------- | ----- | | @apollo/federation-internals | Patch | | @apollo/gateway | Patch | | @apollo/composition | Patch | | @apollo/query-planner | Patch | | @apollo/query-graphs | Patch | | @apollo/subgraph | Patch | | apollo-federation-integration-testsuite | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 4 months ago

Deploy Preview for apollo-federation-docs canceled.

Name Link
Latest commit 057f0a049b9b18af499e7e3eaf0c96b883fd358e
Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/669ffdc6f608d50008c489d2
codesandbox-ci[bot] commented 4 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.