search

apollographql / federation

🌐  Build and scale a single data graph across multiple services with Apollo's federation gateway.
https://apollographql.com/docs/federation/
Other
668 stars 254 forks source link

Update context-matching logic to use earlier path edges if possible #3114

Open sachindshinde opened 3 months ago

sachindshinde commented 3 months ago

This PR updates context-matching logic for @context/@fromContext to use earlier edges in the GraphPath if possible. (Also a bit of logic reorganizing for performance reasons.)

Specifically, if there are key resolution or root-type resolution edges prior to the match point in the graph path, then the context can be resolved at those edges to potentially generate more optimal query plans. (This should have occurred with the handleRequires logic being reapplied to contexts, but it wasn't happening for some reason.)

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: c94dcc3f570b80d4158fd340a70114b40871d61a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for apollo-federation-docs canceled.

Name Link
Latest commit c94dcc3f570b80d4158fd340a70114b40871d61a
Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/66ba2d68e6ccec0007f9cb8a
codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.