search

apollographql / federation

🌐  Build and scale a single data graph across multiple services with Apollo's federation gateway.
https://apollographql.com/docs/federation/
Other
668 stars 254 forks source link

Add missing query graph edge for interfaces implementing interfaces #3122

Closed sachindshinde closed 3 months ago

sachindshinde commented 3 months ago

During addAdditionalAbstractTypeEdges(), we add edges between abstract types, but we specifically were skipping edges between interfaces implementing interfaces because that function expected it to be added already by addAbstractTypeEdges(). However, the latter function only handles edges between concrete (object) and abstract types. This PR accordingly updates addAdditionalAbstractTypeEdges() to stop skipping interfaces-implementing-interfaces edges, and updates tests accordingly.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 7040fba230cac9f482564bf72fa21c871a5d5cf3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages | Name | Type | | --------------------------------------- | ----- | | @apollo/gateway | Patch | | @apollo/query-graphs | Patch | | @apollo/composition | Patch | | @apollo/query-planner | Patch | | @apollo/federation-internals | Patch | | @apollo/subgraph | Patch | | apollo-federation-integration-testsuite | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for apollo-federation-docs canceled.

Name Link
Latest commit 734571021160cce5b849e7365d54e597d738fe5d
Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/66c376cedab0a40008d58875
codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.