apollographql / federation

🌐  Build and scale a single data graph across multiple services with Apollo's federation gateway.
https://apollographql.com/docs/federation/
Other
669 stars 254 forks source link

fix(query-planner): fixed missing referenced variables in the `variableUsages` field #3166

Closed duckki closed 1 month ago

duckki commented 1 month ago

Fixed missing referenced variables in the variableUsages field of fetch operations

Query variables used in fetch operation should be listed in the variableUsages field. However, there was a bug where variables referenced by query-level directives could be missing in the field.

The previous PR (#2986) fixed a similar issue in fetch queries, but it didn't fully fix the issue by failing to update the variableUsages field. This PR completes the remaining issue.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 1a0ba248a4129349096b2e7891df8b6ecf776f99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages | Name | Type | | --------------------------------------- | ----- | | @apollo/query-planner | Patch | | @apollo/query-graphs | Patch | | @apollo/federation-internals | Patch | | @apollo/gateway | Patch | | @apollo/composition | Patch | | @apollo/subgraph | Patch | | apollo-federation-integration-testsuite | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

svc-apollo-docs commented 1 month ago

✅ Docs Preview Ready

No new or changed pages found.

netlify[bot] commented 1 month ago

Deploy Preview for apollo-federation-docs canceled.

Name Link
Latest commit 1a0ba248a4129349096b2e7891df8b6ecf776f99
Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/670b0143d107100008566eb0
codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.