Open grantwwu opened 5 years ago
I guess this is related to promise cancellation..?
https://github.com/apollographql/graphql-subscriptions/blob/master/src/pubsub-engine.ts#L3
subscribe(triggerName: string, onMessage: Function, options: Object): Promise<number>
is problematic because we may want the connection ID (I assume that's what the number is for?) before we connect, in order to say, close it.
Additionally, sometimes we want to be able to cancel a subscription before a Promise returns.
I guess this is related to promise cancellation..?
https://github.com/apollographql/graphql-subscriptions/blob/master/src/pubsub-engine.ts#L3
subscribe(triggerName: string, onMessage: Function, options: Object): Promise<number>
is problematic because we may want the connection ID (I assume that's what the number is for?) before we connect, in order to say, close it.