Bad Definitely Typed definition for Sinon is breaking the build

apollographql / graphql-subscriptions

:newspaper: A small module that implements GraphQL subscriptions for Node.js

MIT License

1.59k stars 133 forks source link

Bad Definitely Typed definition for Sinon is breaking the build #186

Open robbywashere-zz opened 5 years ago

robbywashere-zz commented 5 years ago

The build is outputting the following error, this is referenced in DefinitelyTyped/DefinitelyTyped#30657

node_modules/@types/sinon/index.d.ts:41:20 - error TS2370: A rest parameter must be of an array type.

41         calledWith(...args: TArgs): boolean;
                      ~~~~~~~~~~~~~~
node_modules/@types/sinon/index.d.ts:45:27 - error TS2370: A rest parameter must be of an array type.

45         calledWithExactly(...args: TArgs): boolean;
                             ~~~~~~~~~~~~~~

grantwwu commented 5 years ago

Thanks for pointing this out - I worked around this here: https://github.com/apollographql/graphql-subscriptions/commit/79f63fe31ee9c6ce683c21dc53aa7ee4343cbede

I'm going to leave this open so I remember to unpin the version once they fix this...