pubSub.asyncIterator() return type

apollographql / graphql-subscriptions

:newspaper: A small module that implements GraphQL subscriptions for Node.js

MIT License

1.59k stars 133 forks source link

Open stephentuso opened 5 years ago

stephentuso commented 5 years ago

Shouldn't the return type be AsyncIterableIterator (TS lib file) instead of AsyncIterator? I see it has the Symbol.asyncIterator property here

grantwwu commented 5 years ago

Sounds correct - would you like to make a PR?

stephentuso commented 5 years ago

Will do 👍

ghost commented 4 years ago

Hmm if we use just AsyncIterator<T> how can we check the types of return object? Should we use AsyncIterator<T, TReturn, TNext> instead?

hyochan commented 4 years ago

Any news on this? How I should I have to type below case?

maxpain commented 2 years ago

Any news?