Allow resolver fn to be async

apollographql / graphql-subscriptions

:newspaper: A small module that implements GraphQL subscriptions for Node.js

MIT License

1.59k stars 133 forks source link

Allow resolver fn to be async #220

Closed maclockard closed 2 years ago

maclockard commented 4 years ago

Looking at some possible downstream consumers, these seems fine and not breaking since they can receive an async subscription function:

https://github.com/graphql/graphql-js/blob/master/src/subscription/subscribe.d.ts#L42-L51
https://github.com/apollographql/subscriptions-transport-ws/blob/master/src/server.ts#L69-L78

fixes #213

XavierLeTohic commented 4 years ago

Any news on this?

AadamZ5 commented 4 years ago

@hwillson Can you please glance at this? You're the most recent active contributor of this project. This changes similar files from a PR you've recently merged #229.

Many dependent libraries would benefit from this contribution. Currently, many developers have to employ ugly workarounds to get around this limitation. The lack of async operability is frankly extremely inconvenient in a handful of scenarios.