apollographql / graphql-subscriptions

:newspaper: A small module that implements GraphQL subscriptions for Node.js
MIT License
1.59k stars 133 forks source link

Update `graphql` to 15.x #221

Closed simlu closed 3 years ago

simlu commented 4 years ago

Will open pr shortly

simlu commented 4 years ago

My failed attempt here: https://github.com/apollographql/graphql-subscriptions/pull/222

simlu commented 4 years ago

Looks like there are quite a few dependencies that will need to be updated for apollo server to work with graphql 15.x: https://circleci.com/gh/blackflux/apollo-server-tools/3274

[23:50:17] warning "apollo-server > graphql-subscriptions@1.1.0" has incorrect peer dependency "graphql@^0.10.5 || ^0.11.3 || ^0.12.0 || ^0.13.0 || ^14.0.0".
warning "apollo-server > graphql-tools@4.0.7" has incorrect peer dependency "graphql@^0.13.0 || ^14.0.0".
warning "apollo-server > apollo-server-core > graphql-tag@2.10.3" has incorrect peer dependency "graphql@^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0".
warning "apollo-server > apollo-server-core > graphql-upload@8.1.0" has incorrect peer dependency "graphql@0.13.1 - 14".
warning "apollo-server > apollo-server-core > subscriptions-transport-ws@0.9.16" has incorrect peer dependency "graphql@^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.1 || ^14.0.2".
warning "apollo-server > graphql-tools > apollo-link@1.2.13" has incorrect peer dependency "graphql@^0.11.3 || ^0.12.3 || ^0.13.0 || ^14.0.0".
warning "apollo-server > graphql-tools > apollo-utilities@1.3.3" has incorrect peer dependency "graphql@^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0".
warning "apollo-server > apollo-server-core > apollo-engine-reporting > apollo-graphql@0.4.1" has incorrect peer dependency "graphql@^14.2.1".
innche commented 4 years ago

Similar issue, plus this line: warning "type-graphql > graphql-query-complexity@0.5.0" has incorrect peer dependency "graphql@^0.13.0 || ^14.0.0".

smolinari commented 4 years ago

Same here.

Scott

cuongndc9 commented 4 years ago

any updates?

glen-84 commented 3 years ago

Version 1.2.0 has been released to npm (but is not yet tagged in GitHub). This issue can probably be closed.

/cc @glasser

glasser commented 3 years ago

Oops, sorry about the lack of git push (I'm spoiled by the CI-based publishing we have on other repos). Agreed, this is fixed!