apollographql / graphql-subscriptions

:newspaper: A small module that implements GraphQL subscriptions for Node.js
MIT License
1.6k stars 133 forks source link

Peer Dependency Mismatch #242

Closed DakotaLarson closed 3 years ago

DakotaLarson commented 3 years ago

Hi,

When installing graphql-subscriptions as a dependency of type-graphql or apollo-server-express, I get an error stating it requires a peer dependency of graphql@^0.10.5 || ^0.11.3 || ^0.12.0 || ^0.13.0 || ^14.0.0.

The code in this repo uses ^0.10.5 || ^0.11.3 || ^0.12.0 || ^0.13.0 || ^14.0.0 || ^15.0.0, allowing v15.x which I have installed.

I installed the package fresh from npm in a test folder and got the same peer dependency.

Essentially, can package.json be updated to support v15.x and be in line with the code in this repo?

Thanks!

ezforw commented 3 years ago

having a similar issue there, need support for graphql v15

npm WARN ERESOLVE overriding peer dependency
npm WARN Found: graphql@15.4.0
npm WARN node_modules/graphql
npm WARN   graphql@"^15.4.0" from the root project
npm WARN   43 more (@apollo/client, @graphql-cli/codegen, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer graphql@"^0.10.5 || ^0.11.3 || ^0.12.0 || ^0.13.0 || ^14.0.0" from graphql-subscriptions@1.1.0
npm WARN node_modules/graphql-subscriptions
npm WARN   graphql-subscriptions@"^1.1.0" from openapi-to-graphql@2.2.5
npm WARN   node_modules/openapi-to-graphql
theodorDiaconu commented 3 years ago

The code is there, but I think it's not published to 1.1.0.

theodorDiaconu commented 3 years ago

@hwillson please help us! We hate seeing peer dependencies error mismatch and we're all using graphql@15.

These commands should solve it (for your convenience), as the package.json is already updated:

npm version patch
git push ; git push --tags;
npm publish
glen-84 commented 3 years ago

Version 1.2.0 has been released to npm (but is not yet tagged in GitHub). This issue can probably be closed.

/cc @glasser

glasser commented 3 years ago

Oops, sorry about the lack of git push (I'm spoiled by the CI-based publishing we have on other repos). Agreed, this is fixed!