search

apollographql / graphql-subscriptions

:newspaper: A small module that implements GraphQL subscriptions for Node.js
MIT License
1.58k stars 133 forks source link

Release 3.0 #250

Open hwillson opened 2 years ago

hwillson commented 2 years ago

This release PR will serve to collect significant new features, deprecation warnings, and minor breaking changes that we intend to release in graphql-subscriptions@3.0.0. It should not be merged until we're ready to release 3.0.

maxpain commented 2 years ago

Any updates?

Narretz commented 2 years ago

Are there any more breaking changes planned? If not, could the release happen? Or even if, could the release happen? There's always the next major version for more breaking changes.

tubbo commented 2 years ago

@hwillson hey this has been blocking a major version upgrade of graphql codegen for us, any chance you could release soon?

daphnesmit commented 2 years ago

Same 👯

Hetch3t commented 2 years ago

Any new improvements planned? What's holding you from merging it finally?

maxpain commented 2 years ago

Any news?

Ryiski commented 1 year ago

1 year and still not ready? not to be rude or anything, what's the hold-up

aidenfoxx commented 1 year ago

Any update would be appreciated? :pray:

MrDesjardins commented 1 year ago

Hello,

I am reading the latest (V4) Apollo documentation that recommend using the graphql-subscriptions library with subscription. However, the type, as mentioned by many people in this thread, are not compatible. I believe this pull request will solve this issue. Apollo is quite a popular and the are fading out their v3 for v4.

There is a discussion in the graphql-codegen that generate code to use with Apollo that highlight that the issue is not on the generated type. Someone in the Codegen discussion gives a quick hack to fix the issue: 

subscribe: () => ({
        [Symbol.asyncIterator]: () => pubsub.asyncIterator('NUMBER_INCREMENTED'),
      }),

However, the hack is only for type. Doing:

subscribe: () => pubsub.asyncIterator("NUMBER_INCREMENTED") as any,

Also fix the problem.

The first comment of this thread is from Nov 25, 2021 and we are now almost over with 2022. The direction of this library is unclear to me but it is an helpful one and it would be great to see it moving forward to continue to work with TypeScript without hacks. Have a great day.

Aeolun commented 1 year ago

@hwillson Is this something that is still on the agenda? Migrating to apollo v4 would be a lot more pleasant without conflcting types.