Closed xavxyz closed 7 years ago
Two objects I think.
So should we change the API from:
meteorClientConfig(networkInterfaceConfig)
to:
meteorClientConfig(clientConfig)
and clientConfig
can take any Apollo Client options plus networkInterfaceConfig
? Which would be overwritten if clientConfig.networkInterface
were included?
And we can explain what defaults we use
Yep totally!
Want to do that to this PR & docs changes? Or separately?
I'll do the modifications on this one 👍
💃
And it's working on the starter-kit 🆗
It's me again! 😄
Query deduplication can be pretty handy, I've thought it would be a good thing to offer Meteor developers using this package to set deduplication option up.
I believe this open the door to a new way to configure the Apollo Client via the Meteor
apollo
package, given all the params an Apollo Client instance accepts.I see especially two types of config:
ssrMode
,queryDeduplication
&dataObjectFromId
)We could have two types of default config, the
defaultNetworkInterfaceConfig
anddefaultClientOptions
? Or maybe everything in the same object?I don't know what would be the easiest and the most useful for Meteor folks. What do you think?