search

apollographql / reason-apollo

Reason binding for Apollo Client and React Apollo
MIT License
550 stars 108 forks source link

Support react-apollo >=3 ? #208

Open elnygren opened 5 years ago

elnygren commented 5 years ago

package.json says "react-apollo": "^2.5.8",

Is updating something else necessary for reeact-apollo 3 ?

https://github.com/apollographql/react-apollo/releases

elnygren commented 5 years ago

It seems that at least my project is working with this:

"resolutions": {
    "react-apollo": "3.0.1"
}

I'm using Query, Mutation and ApolloConsumer in reasonml but the currently the amount of reasonml is limited so I can't say with certainty that everything definitely works.

nlfiedler commented 5 years ago

I tried moving from 2.5.8 to 3.0.1 in my project, using reason-apollo 0.17.0, and it failed immediately:

[Error] Invariant Violation: Could not find "client" in the context or passed in as a prop. Wrap the root component in an <ApolloProvider>, or pass an ApolloClient instance in via props.
[Error] The above error occurred in the <Query> component:
    in Query (created by ReasonApolloQuery$Make)
    in ReasonApolloQuery$Make (created by Home$Component)
    in Home$Component (created by Index$App)
    in main (created by Index$App)
    in div (created by Index$App)
    in Index$App
    in ApolloProvider

So there are some changes needed somewhere.