Open nathanmarcos opened 1 year ago
This seems very reasonable, would you be open to make a PR for this?
There might be a subtlety around it being enabled: true if an other key is set, and we'd probably need a migration.
Sure thing, @o0Ignition0o ! I created a draft for you to have a look. I'm pretty sure there are some things to be improved/added to it. 😄
cc @BrynCooke and @abernix, does this configuration proposal look sensible to you?
Hello @o0Ignition0o , I just resolved some small conflicts on that PR and it's ready for review again. Please, let me know if there is anything else I can do to help move it forward.
Is your feature request related to a problem? Please describe. The Redis cache for APQ and Query Planning are enterprise features and require a "service" Apollo key to operate. We use the exact same
router.yaml
file for all environments and we change the configuration via env vars. On our local env we run the application without an Apollo key since we load the supergraph from a file, but the application doesn't boot up due to the following error:Describe the solution you'd like We would love to have the ability of turning Redis cache off via env var in the
router.yaml
file, example:Describe alternatives you've considered As an alternative solution, you could change those errors to WARN and let the application run without those 2 features when the Apollo key is not set.