Test axum_factory::tests::test_supergraph_timeout fails if port 4000 is in use

apollographql / router

A configurable, high-performance routing runtime for Apollo Federation 🚀

https://www.apollographql.com/docs/router/

Other

813 stars 272 forks source link

Test axum_factory::tests::test_supergraph_timeout fails if port 4000 is in use #3567

Open glasser opened 1 year ago

glasser commented 1 year ago

The test axum_factory::tests::test_supergraph_timeout does not use an ephemeral port, so cargo test fails if port 4000 is in use (for example, if you just happen to be running a router with default configuration).

abernix commented 8 months ago

@nicholascioli Did you possibly fix this recently?

nicholascioli commented 7 months ago

Yes! This PR makes the router bind to a random port for the integration tests. Is this issue happening even after the linked change?