Open Geal opened 12 months ago
The two dependency thing is because jsonpath-lib
is abandoned and buggy. jsonpath-rust
is newer and works.
jsonpath-rust
is used in config analytics.
It's be worth looking at https://github.com/mitghi/jetro to see if it can replace some of our code.
In https://github.com/apollographql/router/pull/3852, I need to update the following configuration:
to:
For the
traffic_shaping.all
path, I can write the migration:But for the
products
subgraph, where I would write a path liketraffic_shaping.subgraphs..experimental_enable_http2
, I cannot execute the move, because the target path should refer to the path that was matched.I cannot find a way to do it in the migration code so far, because neither jsonpath-lib nor jsonpath-rust (why do we even have 2 dependencies for that?) can give the path that was matched, they only provide the value.
In the execution service, we have code that can actually select values from json and give the matched path, maybe I'll replace the current migrations with that