Sending graphql request with empty string as operationName produce invalid response

[IvanGoncharov]

Describe the bug Issue was reported by @bonnici in Slack: https://apollograph.slack.com/archives/C02UX05LF4K/p1710991184963719 Here is example of requests producing invalid responses:

{ 
  "operationName": "", 
   "query": "query ExampleQuery { me { id } }"
}

Router responses with:

{"data":null}

To Reproduce Steps to reproduce the behavior:

1. Run following using starstuff:

   curl -H 'Content-Type: application/json' http://127.0.0.1:4000/ -d '{ "operationName": "", "query": "query { me { id } }" }'

2. See {"data":null} as result

Expected behavior It should be a response containing the error and without data.

https://spec.graphql.org/October2021/#GetOperation()

[bonnici]

I think this is causing some errors related to usage reporting. Now when I try to submit the same payload, I see the router error:

client error reported at ingress: If you see this frequently in your logs, please reach out to support@apollographql.com.
Details: Unparseable statsRecordKey with invalid metadata for graph BR-074-Tester@playground:

We're seeing this error come up very frequently for some customers, especially within the last week.

[smyrick]

According to the spec, then should this JSON body run the operation with no errors? As the name is empty and the string is empty

curl -H 'Content-Type: application/json' http://127.0.0.1:4000/ -d '{ "operationName": "", "query": "query { me { id } }" }'

vs this is mismatch

curl -H 'Content-Type: application/json' http://127.0.0.1:4000/ -d '{ "operationName": "", "query": "query Hello { me { id } }" }'

[timbotnik]

Similarly wondering if this happens for any mismatch of operation name not found in the document.

[SimonSapin]

According to the spec, then should this JSON body run the operation with no errors? As the name is empty and the string is empty

I think not, because the empty string is different from null / absent