apollographql / router

A configurable, high-performance routing runtime for Apollo Federation 🚀
https://www.apollographql.com/docs/router/
Other
800 stars 268 forks source link

Remove pruning when computing best plan #6053

Closed sachindshinde closed 3 days ago

sachindshinde commented 3 days ago

This PR removes option pruning in compute_best_plan_from_closed_branches(), as it has been removed from JS QP. (The reasoning was that it was observed pruning could save time in some cases, but could be substantially worse in a few others.) Note that we should also be able to get rid of overriding IDs, although that requires changing more code (and the JS QP hasn't done it yet either), so I'm leaving it to the future/later PRs.

github-actions[bot] commented 3 days ago

@sachindshinde, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.