apollographql / router

A configurable, high-performance routing runtime for Apollo Federation 🚀
https://www.apollographql.com/docs/router/
Other
800 stars 268 forks source link

Updating redis and subgraphs configs to be children of preview_entity… #6059

Open apollonauttrey opened 3 days ago

apollonauttrey commented 3 days ago

…_cache

Customer shared that when they were configuring (through trial and error) they discovered that the redis config should be a child of preview_entity_cache - upon making this change, I believe the same is true for the subgraphs config.

Description here

Fixes #issue_number


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

apollo-cla commented 3 days ago

@apollonauttrey: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Geal commented 2 days ago

which version of the router are they using? Did you check with the config schema?

apollonauttrey commented 2 days ago

1.50

apollonauttrey commented 2 days ago

i think that's a reasonable compromise @Meschreiber - 1.50 was only late june/early july so it's possible someone else could run into this.

Geal commented 1 day ago

note that this is still a preview feature, so things like configuration could change a bit before GA