fix(federation): Unnecessary fragment removal should occur before rebasing

apollographql / router

A configurable, high-performance routing runtime for Apollo Federation 🚀

https://www.apollographql.com/docs/router/

Other

800 stars 268 forks source link

fix(federation): Unnecessary fragment removal should occur before rebasing #6060

Closed sachindshinde closed 3 days ago

sachindshinde commented 3 days ago

This PR fixes a bug where unnecessary fragment removal was occurring after rebasing instead of before it (like in JS QP), resulting in cases where the field's parent type wouldn't match the selection set it was being added to.

github-actions[bot] commented 3 days ago

@sachindshinde, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.