apollographql / router

A configurable, high-performance routing runtime for Apollo Federation 🚀
https://www.apollographql.com/docs/router/
Other
813 stars 271 forks source link

Fix introspection false mismatch: defaultValue list of objects #6075

Closed SimonSapin closed 1 month ago

SimonSapin commented 1 month ago

In GraphQL introspection response, the defaultValue of an anrgument or input object field is represented as a JSON string that contains GraphQL syntax. If that value contains a GraphQL object value, graphql-js seems to sort its contents by input object field name whereas apollo-compiler preserves the source ordering.

This causes introspection JSON responses to be different in a way that we consider not to be meaningful: object values are semantically unordered maps. Introspection "both" mode already had code to sort object values in order to ignore these differences, but was missing the case where defaultValue is not directly an object value but a list value of object values.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

github-actions[bot] commented 1 month ago

@SimonSapin, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.