apollographql / router

A configurable, high-performance routing runtime for Apollo Federation 🚀
https://www.apollographql.com/docs/router/
Other
813 stars 271 forks source link

fix: add backticks around incorrect variable name #6171

Closed lennyburdette closed 3 weeks ago

lennyburdette commented 1 month ago

"expected $this, got this" is confusing, so hopefully "expected $this, got `this`" helps


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

Exceptions

Note any exceptions here

Notes

[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

svc-apollo-docs commented 1 month ago

✅ Docs Preview Ready

Configuration ```json { "repoOverrides": { "apollographql/router@next": { "remote": { "owner": "apollographql", "repo": "router", "branch": "lb/next/confusing-error" } } } } ```
Name Link
Commit f66722951698eba3dcbd5591c10000a9b0c41122
Preview [https://www.apollographql.com/docs/deploy-preview/d1e1e3bc725bba136a83](https://www.apollographql.com/docs/deploy-preview/d1e1e3bc725bba136a83)
Build ID d1e1e3bc725bba136a83
File Changes
0 new, 1 changed, 0 removed ``` * graphos/reference/federation/errors.mdx ```
Pages 1

1 pages published. Build will be available for 30 days.

router-perf[bot] commented 1 month ago

CI performance tests