Open goto-bus-stop opened 1 day ago
No new or changed pages found.
@goto-bus-stop, please consider creating a changeset entry in /.changesets/
. These instructions describe the process and tooling.
CI performance tests
Wait. Why are there two QP configurations?
https://github.com/apollographql/router/blob/dc0426c8f578126abcf0cbbeb7fbb5a51c2eb16d/apollo-router/src/configuration/mod.rs#L416-L430 https://github.com/apollographql/router/blob/dc0426c8f578126abcf0cbbeb7fbb5a51c2eb16d/apollo-router/src/query_planner/bridge_query_planner.rs#L169-L182
The experimental
max_evaluated_plans
andpaths_limit
options were only propagated to the legacy JS planner, not the native query planner.Now they work with both planners.
It would be nice to write an integration test. Perhaps by running a query from the apollo-federation test suite and then asserting on the metric value?
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.