search

apollographql / rover

The CLI for Apollo GraphOS
https://rover.apollo.dev
Other
404 stars 84 forks source link

Generating type "federation__FieldSet!" instead of "_FieldSet!" when doing rover graph introspect #1790

Closed omer727 closed 3 weeks ago

omer727 commented 9 months ago

Description

getting _federation_FieldSet instead of _FieldSet

Steps to reproduce

I'm running rover graph introspect http://localhost:4006/graphql on a graphql with line extend schema @link(url: "https://specs.apollo.dev/federation/v2.5", import: ["@key"])

and getting directive @key(fields: _federation_FieldSet!, resolvable: Boolean = true) on OBJECT | INTERFACE then I'm publishing the schema file using this command: rover subgraph publish <APOLLO_REF> --name <name> --routing-url http://localhost:4006 --schema ./<generated file> and getting DIRECTIVE_DEFINITION_INVALID : Invalid definition for directive "@key": argument "fields" should have type "_FieldSet!" but found type "federation__FieldSet!"

Expected result

The publish should work successfully

Actual result

getting DIRECTIVE_DEFINITION_INVALID : Invalid definition for directive "@key": argument "fields" should have type "_FieldSet!" but found type "federation__FieldSet!"

Environment

Rover Info:

Version: 0.21.0 Install Location: /opt/homebrew/bin/rover OS: Mac OS 14.1.1 [64-bit] Shell: /bin/zsh

lib info

"@apollo/subgraph": "^2.5.7", "@apollo/server": "^4.9.3",

jonathanrainer commented 1 month ago

Hi @omer727,

Could it be possible you're trying to publish a v2 schema to somewhere that's expecting a v1 schema, as per this comment here https://github.com/apollographql/federation-hotchocolate/issues/59#issuecomment-1826405269?

That's the kind of thing I'd expect from the error you're seeing.

jonathanrainer commented 3 weeks ago

Hi @omer727 , thanks again for raising this, since it's been over a month I'm going to close this issue. Obviously you've still got the links if you want to explore further. If you're having more problems please feel free to re-open the issue and we can take another look. Thanks!