Add LSP functionality to Rover

apollographql / rover

The CLI for Apollo GraphOS

https://rover.apollo.dev

Other

409 stars 85 forks source link

Add LSP functionality to Rover #2272

Open jonathanrainer opened 3 days ago

jonathanrainer commented 3 days ago

Now that the LSP has been finalised, and composition has been refactored such that it can consume events in the same way that rover dev does we can unify the two together.

This has been tested by running a custom build version of Rover against VSCode and it seems to function as intended. We will need to hash out a few more things in the review overall but this is a very positive step forwards

svc-apollo-docs commented 3 days ago

✅ Docs Preview Ready

No new or changed pages found.

jonathanrainer commented 2 days ago

Also a general comment:

@dylan-apollo I couldn't see a way to inject a profile into the Rover invocation for the LSP, which meant I had to mess around to get my default profile set up. Is this intentional or did I miss something?