dockerize rover - Githubissues

apollographql / rover

The CLI for Apollo GraphOS

https://rover.apollo.dev

Other

407 stars 85 forks source link

dockerize rover #719

Open cyberhck opened 3 years ago

cyberhck commented 3 years ago

Dockerize Rover and publish to docker registry

As the title suggests, it'd be quite nice if apollo team could build official rover docker CLI and publish to docker.

While anyone is able to do this, I think publishing from rover's CI pipeline would mean it'll automatically get updates when there's a new release in rover.

Add details like:

On every merge to master it publishes docker with a "master" tag, on actual tag release, it tags the docker image with that tag. In both cases it's available on docker hub.
Same as rover CLI
I'm sure there are people who dockerized this for their needs.
I want to run this on my post-sync hook when my deployment passes. I don't want to do this from CI because there'll be a gap between CI pushing schema and service getting deployed (also what if the deployment fails),

cyberhck commented 3 years ago

we'll probably need different variant:

distroless
alpine
scratch being 3 main ones.

prasek commented 3 years ago

@cyberhck this sounds very similar to https://github.com/apollographql/supergraph-demo-k8s-graph-ops/issues/50

Run auto publish subgraph schema in an Argo Rollout postPromotionAnalysis job that runs rover in a docker container.

Can you provide some more context on this:

I want to run this on my post-sync hook when my deployment passes

Is this https://argoproj.github.io/argo-cd/user-guide/resource_hooks/?

cyberhck commented 3 years ago

I'm just asking for an official docker image, and in case someone is curious why, I've mentioned the reason.

While we can publish docker ourselves, having apollo's ci do that is better

cyberhck commented 3 years ago

would you be open to a PR? I'd be okay with writing a Dockerfile and a github workflow to dockerize and push to docker hub if you'd prefer.

cyberhck commented 3 years ago

also, where will it release? docker hub? github registry? I'll need someone to setup secrets

carlocorradini commented 2 years ago

Any update on this? It could be super useful...

We can dockerize it as Apollo Router and publish it on GitHub Packages.

What do you think? 🤯🥳

cyberhck commented 2 years ago

Will Apollo Router be able to do everything that rover does?

olivernybroe commented 2 years ago

While waiting for this feature, we created a small wrapper for our needs (really low effort added) 👍

We only use it for publishing the subgraph as a job in k8s. You can find our docker wrapper here https://hub.docker.com/repository/docker/worksome/rover/general https://github.com/worksome/rover