apolopena / gitpod-laravel-starter

Configurable LAMP or LEMP stack starter project powered by Laravel and Gitpod. Supports Laravel 6, 7, and 8. Out of the box support for React, Vue, and Bootstrap frontends, with or without built-in auth .
https://github.com/apolopena/gitpod-laravel-starter/wiki
MIT License
40 stars 44 forks source link

9660+ extra files in phpmyadmin install #10

Closed apolopena closed 3 years ago

apolopena commented 3 years ago

Describe the bug

composer libraries in /public/phpmyadmin/vendor are bloating the phpmyadmin optional install Branch: development

Screenshots

image

Steps to reproduce

  1. Build a Gitpod workspace with INSTALL_PHPMAYADMIN=1 in starter.ini
  2. Go to the dash board and look at that workspace. There will be around 9663

Expected behavior

Should probably be less than a couple hundred files overall for just Laravel and phpmyadmin installs.

Additional information

Probably just need to dynamically add /vendor/public/phpmyadmin to /.gitignore

apolopena commented 3 years ago

will have to do a .gitignore on the entire phpmyadmin folder as there are 2500+ files in there no matter what. Installations of the project outside of gitpod will have their own seperate set of deployment steps. Regarding github: The phpmyadmin install will exist for the life time of the workspace so that will work for development purposes