apolopena / gitpod-laravel-starter

Configurable LAMP or LEMP stack starter project powered by Laravel and Gitpod. Supports Laravel 6, 7, and 8. Out of the box support for React, Vue, and Bootstrap frontends, with or without built-in auth .
https://github.com/apolopena/gitpod-laravel-starter/wiki
MIT License
40 stars 44 forks source link

React example presets have some bad css/sass #184

Closed apolopena closed 2 years ago

apolopena commented 2 years ago

Describe the bug

Styling problems have appeared for the example projects that use bootstrap css.

This is a regression possibly due to hotfix 140

Screenshots

image

Steps to reproduce

https://gitpod.io/#EXAMPLE=1/https://github.com/apolopena/gitpod-laravel-starter/tree/development

Expected behavior

Additional information

The sass version should really no longer be pinned to an old version which is what had to be done for hotfix 140

Perhaps removing hotfix140 from the example projects that use bootstrap will automagically solve the problem.

apolopena commented 2 years ago

Its not hotfix 140, however this will be removed as it is no longer needed.

apolopena commented 2 years ago

It appears that this is a bootstrap 5 vs boostrap 4 issue.

Laravel updates its version of bootstrap when it makes minor version changes and since gitpod-laravel-starter uses Laravel 8.* the version that example projects use will get their bootstrap (and other packages) package version bumped up.

apolopena commented 2 years ago

Will attempt to fix this with https://github.com/apolopena/gitpod-laravel-starter/issues/185 and may also involve https://github.com/apolopena/gitpod-laravel-starter/issues/186